Skip to content

Refactor eng/common/README.md#1178

Merged
2 commits merged intoAzure:masterfrom
chidozieononiwu:feature/RefactorEngCommonWorkflow
Nov 10, 2020
Merged

Refactor eng/common/README.md#1178
2 commits merged intoAzure:masterfrom
chidozieononiwu:feature/RefactorEngCommonWorkflow

Conversation

@chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Nov 7, 2020

Move Common Engineering System Doc to main README.md Doc.
Add information for how to structure unique language logic.

@chidozieononiwu chidozieononiwu requested a review from a team as a code owner November 7, 2020 00:21
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 7, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Nov 9, 2020
View reviewed changes
weshaggard
weshaggard reviewed Nov 9, 2020
View reviewed changes
@chidozieononiwu chidozieononiwu requested review from a team and weshaggard November 9, 2020 18:51
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 9, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Nov 9, 2020
View reviewed changes
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 10, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Nov 10, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@chidozieononiwu chidozieononiwu force-pushed the feature/RefactorEngCommonWorkflow branch from 71e9052 to 7ac8028 Compare November 10, 2020 02:08
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 10, 2020

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Nov 10, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 2c58ce4 into Azure:master Nov 10, 2020
@chidozieononiwu chidozieononiwu mentioned this pull request Nov 11, 2020
Closed
benbp pushed a commit that referenced this pull request Dec 1, 2020
@chidozieononiwu @benbp
Refactor eng/common/README.md (#1178)
3e32c6e 
Move Common Engineering System Doc to main README.md Doc.
Add information for how to structure unique language logic.
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
@ericwolz
IoT SDK review updates (Azure#1178)
a3ad79c 
* az_iot_is_retriable_status

* update

* update

* update

* doc update

* update change log

* fix doxgen build break

* fixed PR issues

* added more context to global_device_hostname

* Update .gitignore

* Update CHANGELOG.md

* pr review

* Update az_iot_provisioning_client.c
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchdenny mitchdenny mitchdenny approved these changes

@weshaggard weshaggard weshaggard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chidozieononiwu @azure-sdk @mitchdenny @weshaggard